Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #31467 #34997 #35059

Conversation

kerneltime
Copy link

@kerneltime kerneltime commented Oct 18, 2016

Cherry pick of #31467 #34997 on release-1.4

#34997: Fix kube vsphere.kerneltime
#31467: Add support for vpshere cloud provider in kubeup

Ref: 34997 for discussion.


This change is Reviewable

Ritesh H Shukla and others added 5 commits October 18, 2016 19:50
When deploying on vSphere using kube up add configuration
for vSphere cloud provider.
Use state.show_highstate to wait for init highstate functions to be done on each node.
Then start highstate in parallel on all the minions.
Use ComputeResource instead of ClusterComputeResource when
initializing the vSphere Cloud Provider
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Oct 18, 2016
@jessfraz jessfraz added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Oct 18, 2016
@jessfraz jessfraz added this to the v1.4 milestone Oct 18, 2016
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Oct 18, 2016
@jessfraz jessfraz self-assigned this Oct 18, 2016
@jessfraz jessfraz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit c5dcb39. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@jessfraz
Copy link
Contributor

@ixdy the etcd3 test shouldn't work on PRs to older branches right?

@ixdy
Copy link
Member

ixdy commented Oct 18, 2016

@jessfraz yeah, I expect it would fail.
@spxtr is there a way in prow to disable triggering tests on certain release branches? that'd be more elegant than the "if old release just pass" option we currently use (though I guess not on etcd3).

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit abc6df1 into kubernetes:release-1.4 Oct 18, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…-of-#31467-kubernetes#34997-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#31467 kubernetes#34997 

Cherry pick of  kubernetes#31467 kubernetes#34997 on release-1.4

kubernetes#34997: Fix kube vsphere.kerneltime
kubernetes#31467: Add support for vpshere cloud provider in kubeup

Ref: 34997 for discussion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants